Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depcheck github action #869

Closed
karkir0003 opened this issue Jul 15, 2023 · 0 comments · Fixed by #1067
Closed

depcheck github action #869

karkir0003 opened this issue Jul 15, 2023 · 0 comments · Fixed by #1067
Assignees
Labels
Quality Fix Fixes that improve code quality

Comments

@karkir0003
Copy link
Member

Problem: We have instances where we install a frontend library with yarn, but then we don't actually end up using it in our code. We should try to keep our frontend package size as small as possible and keep only the essentials to make our builds run faster

Solution: Use depcheck to create a Github Action that validates that there are no frontend libraries in yarn.lock that really don't get used.

Branch Setup:

git checkout nextjs
git pull origin nextjs
git checkout -b depcheck-action
@karkir0003 karkir0003 added the good first issue Good for newcomers label Jul 15, 2023
@karkir0003 karkir0003 added the Quality Fix Fixes that improve code quality label Aug 21, 2023
@prishavall prishavall removed the good first issue Good for newcomers label Oct 24, 2023
@karkir0003 karkir0003 linked a pull request Nov 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality Fix Fixes that improve code quality
Projects
Archived in project
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants