Identify inactive participants #6
Conversation
There was a problem hiding this comment.
@SaiNikhileshReddy It would be better to print out along with what's already being printed (partner list for example) + saving it to a CSV file (pairs for example).
|
Partners list is getting printed to a csv file with "Week_"+week_no+".csv" from starting. You wanted inactive ppl in a json, so I did that. |
|
Can you be more precise? |
|
@SaiNikhileshReddy Ah nope, inactive people we need in CSV. A CSV file can be imported to contacts either directly or by converting to a VCF file. JSON can't be. Also that list only needs to contain inactive people. Also, Right now what I'm doing is that I'm taking last 3 weeks, putting into one sheet, cleaning duplicates and saving to contacts. And then I'll check the group. Whoever isn't in my contacts are the ones to be deleted. Having this feature in code itself saves time. Also when we say 3 weeks, are you including current week + last 2 weeks or last 3 weeks excluding current week? |
|
last three weeks and current week is not included into the json because they are not final yet. I'll print them to csv. |
|
Fixed known issues. Removed json and replaced it with .csv for active and inactive participants. Let me know how it is working on your end. |
There was a problem hiding this comment.
@SaiNikhileshReddy Take a look at this: https://github.com/DSC-ASEB/Weekly-Shuffle-Partner-Generator/pull/6/checks?check_run_id=2520847978
They need fixing.
|
They are fixed now. |
|
This pull request fixes 1 alert when merging 3f671ba into 89eaf7d - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 40d85e7 into c1fc812 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 8d639c5 into c1fc812 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging a342d53 into c1fc812 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
@SaiNikhileshReddy DeepSource is a static code analysing tool. You can find the 2 issues mentioned here where the description is also given. Only those 2 are left. Once that's done, I'll add test data to the test. Right now, it's already running tests on every commit as you can see here. Expand to see the output.
It's reported by Pylint. You can read more about PYL-R1718 and PYL-W0621 in that link above itself or by searching online.
Click on the hyperlinks to learn more.
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
|
This pull request fixes 1 alert when merging e11fc22 into c1fc812 - view on LGTM.com fixed alerts:
|
…SC-ASEB/Weekly-Shuffle-Partner-Generator into issue-5-Identify_inactive_participants
|
This pull request fixes 1 alert when merging 59d3708 into c1fc812 - view on LGTM.com fixed alerts:
|
|
All checks are done. Can you execute the code on your system for any issues. We can close the PR if the issues are fixed. |
|
This pull request fixes 1 alert when merging 2c7e703 into c1fc812 - view on LGTM.com fixed alerts:
|
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
aravindvnair99
force-pushed
the
issue-5-Identify_inactive_participants
branch
from
2c7e703 to
8a751be
Compare
|
This pull request fixes 1 alert when merging 8a751be into c1fc812 - view on LGTM.com fixed alerts:
|
Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
…tner-Generator into issue-5-Identify_inactive_participants
aravindvnair99
changed the title
aravindvnair99
changed the title
There was a problem hiding this comment.
@SaiNikhileshReddy The algorithm seems wrong. I can see active being listed as inactive. Check output here: https://github.com/DSC-ASEB/Weekly-Shuffle-Partner-Generator/pull/6/checks?check_run_id=2647728690
|
This pull request fixes 1 alert when merging 3e771bd into 62af3aa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 343f465 into 8ea7bc8 - view on LGTM.com fixed alerts:
|
Added Changes