Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Function: OutputChannel - Get Channel Key #5

Open
HpLightcorner opened this issue Jul 9, 2020 · 0 comments
Open

Missing Function: OutputChannel - Get Channel Key #5

HpLightcorner opened this issue Jul 9, 2020 · 0 comments

Comments

@HpLightcorner
Copy link
Contributor

Issue
I am adding and deleting output channels dynamically (or to be more precise - according to a setup-file) to my plugin. I want to compare to the unique-channel key, and if the present channel key was removed from the settings file, I am going to delete the output-channel in oxygen as well. To do so, I need the INSTANCE_CHANNEL_KEY property.

My current source code looks like this:
const auto& key_property = std::dynamic_pointer_cast<EditableStringProperty>(channels_to_question[i]->getProperty("SoftwareChannelInstanceKey"));

as the INSTANCE_CHANNEL_KEY is defined private in odkfw_software_channel_instance.cpp.

Suggested Solution
Add a function to PluginChannel allowing to get the INSTANCE_CHANNEL_KEY property. Alternativly, make INSTANCE_CHANNEL_KEY a global, public define.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant