From 38462fe5d0ec07278dfea34c5ce4a7213870e165 Mon Sep 17 00:00:00 2001 From: Roble Date: Wed, 1 May 2024 13:21:38 +0100 Subject: [PATCH 1/3] How do you want to set up H1 Title text change https://eaflood.atlassian.net/browse/WATER-4413 This is a PR focused on changing the how do you want to setup H1 title from the old title ('How do you want to set up the return requirement?') to the new title ('How do you want to set up the requirements for returns?'). From 59c0bff02672cc3171b169bd047bbbdbacdd9c96 Mon Sep 17 00:00:00 2001 From: Roble Date: Wed, 1 May 2024 13:28:53 +0100 Subject: [PATCH 2/3] Update old h1 title to the new h1 title --- app/routes/return-requirement.routes.js | 2 +- app/services/return-requirements/setup.service.js | 2 +- app/services/return-requirements/submit-setup.service.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/routes/return-requirement.routes.js b/app/routes/return-requirement.routes.js index 1c9376c0e6..324d6108a0 100644 --- a/app/routes/return-requirement.routes.js +++ b/app/routes/return-requirement.routes.js @@ -338,7 +338,7 @@ const routes = [ scope: ['billing'] } }, - description: 'How do you want to set up the return requirement?' + description: 'How do you want to set up the requirements for returns?' } }, { diff --git a/app/services/return-requirements/setup.service.js b/app/services/return-requirements/setup.service.js index dd429b2abf..7c8c510174 100644 --- a/app/services/return-requirements/setup.service.js +++ b/app/services/return-requirements/setup.service.js @@ -23,7 +23,7 @@ async function go (sessionId) { return { activeNavBar: 'search', - pageTitle: 'How do you want to set up the return requirement?', + pageTitle: 'How do you want to set up the requirements for returns?', ...formattedData } } diff --git a/app/services/return-requirements/submit-setup.service.js b/app/services/return-requirements/submit-setup.service.js index 5b06630445..539d951952 100644 --- a/app/services/return-requirements/submit-setup.service.js +++ b/app/services/return-requirements/submit-setup.service.js @@ -41,7 +41,7 @@ async function go (sessionId, payload) { return { activeNavBar: 'search', error: validationResult, - pageTitle: 'How do you want to set up the return requirement?', + pageTitle: 'How do you want to set up the requirements for returns?', ...formattedData } } From 87626bffcaeb6e639e6e4163c6a37cffee375dcf Mon Sep 17 00:00:00 2001 From: Roble Date: Wed, 1 May 2024 13:29:19 +0100 Subject: [PATCH 3/3] Updating Setup test files that encounter new h1 title change --- test/controllers/return-requirements.controller.test.js | 4 ++-- test/services/return-requirements/setup.service.test.js | 2 +- .../services/return-requirements/submit-setup.service.test.js | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/controllers/return-requirements.controller.test.js b/test/controllers/return-requirements.controller.test.js index 1ab1af2880..a353515e69 100644 --- a/test/controllers/return-requirements.controller.test.js +++ b/test/controllers/return-requirements.controller.test.js @@ -256,7 +256,7 @@ describe('Return requirements controller', () => { describe('GET /return-requirements/{sessionId}/setup', () => { beforeEach(async () => { Sinon.stub(SetupService, 'go').resolves({ - id: '8702b98f-ae51-475d-8fcc-e049af8b8d38', pageTitle: 'How do you want to set up the return requirement?' + id: '8702b98f-ae51-475d-8fcc-e049af8b8d38', pageTitle: 'How do you want to set up the requirements for returns?' }) }) describe('when the request succeeds', () => { @@ -264,7 +264,7 @@ describe('Return requirements controller', () => { const response = await server.inject(_options('setup')) expect(response.statusCode).to.equal(200) - expect(response.payload).to.contain('How do you want to set up the return requirement?') + expect(response.payload).to.contain('How do you want to set up the requirements for returns?') }) }) }) diff --git a/test/services/return-requirements/setup.service.test.js b/test/services/return-requirements/setup.service.test.js index 04070d5078..a3329cf221 100644 --- a/test/services/return-requirements/setup.service.test.js +++ b/test/services/return-requirements/setup.service.test.js @@ -45,7 +45,7 @@ describe('Select Reason service', () => { expect(result).to.equal({ activeNavBar: 'search', - pageTitle: 'How do you want to set up the return requirement?', + pageTitle: 'How do you want to set up the requirements for returns?', licenceRef: '01/ABC', setup: null }, { skip: ['id'] }) diff --git a/test/services/return-requirements/submit-setup.service.test.js b/test/services/return-requirements/submit-setup.service.test.js index eb8ed39739..7fe4a0c7d0 100644 --- a/test/services/return-requirements/submit-setup.service.test.js +++ b/test/services/return-requirements/submit-setup.service.test.js @@ -69,7 +69,7 @@ describe('Submit Setup service', () => { expect(result).to.equal({ activeNavBar: 'search', licenceRef: '01/ABC', - pageTitle: 'How do you want to set up the return requirement?', + pageTitle: 'How do you want to set up the requirements for returns?', setup: null }, { skip: ['id', 'error'] }) })