Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of bounding box disappears after hover over text #830

Open
jinh0 opened this issue May 18, 2022 · 3 comments
Open

Selection of bounding box disappears after hover over text #830

jinh0 opened this issue May 18, 2022 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Severity: LOW Minor problem or a feature that would make life easier. UI User interface problem

Comments

@jinh0
Copy link
Collaborator

jinh0 commented May 18, 2022

If you selected a bounding box on a folio and then hovered over the text area (on the sidebar) corresponding to that bounding box, the selection color (red) disappears.

This is probably because the logic for hovering over the text area does not consider an already selected bounding box.

Screen.Recording.2022-05-18.at.10.20.00.AM.mov
@jinh0 jinh0 added bug Something isn't working UI User interface problem Severity: LOW Minor problem or a feature that would make life easier. labels May 18, 2022
@yinanazhou
Copy link
Member

Minor fix still needed:

After selecting the bbox, when click on another bbox's text, the latter bbox is selected, but not highlighted in red.

image

@yinanazhou
Copy link
Member

Hi @JoyfulGen, I've pushed the changes for the minor issue.

@JoyfulGen
Copy link
Contributor

Hi @jinh0 and @yinanazhou, the changes work! I've found another small related issue though:
Normally, when you select a bounding box, its corresponding syllable in the text box becomes highlighted. However, if the "Text" checkbox isn't checked at first and I select a bounding box and then check the "Text" box, the bounding box I selected stays highlighted, but its corresponding syllable doesn't highlight at all.

Syllable.not.highlighted.mov

@jinh0 jinh0 self-assigned this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Severity: LOW Minor problem or a feature that would make life easier. UI User interface problem
Projects
None yet
Development

No branches or pull requests

3 participants