Switch Operator dispose order

[ProffP]

The switch operator in R3 will observe the next inner observable before disposing the current.

This is inconsistent with the behaviour of ReactiveExtensions. So when migrating from ReactiveExtensions I had to define a new operator where the SerialDisposable was assigned Disposable.Empty prior to the new observation.

I’m not sure that this is a big issue as it’s easy to produce new operators, perhaps a Boolean can be passed to change the order or it’s something to note in the method description in some way.

[neuecc]

Thank you for the detailed explanation.
I consider this to be an unintended incompatibility that needs to be fixed.
Please wait a moment, I will definitely fix it.

[ProffP]

Great, thanks 👍

[ProffP]

For reference, the code in ReactiveExtensions: https://github.com/dotnet/reactive/blob/main/Rx.NET/Source/src/System.Reactive/Linq/Observable/Switch.cs

It seems that there is an InnerObserver class that has a Resource set after assigning the SerialDisposable:

public override void OnNext(IObservable<TSource> value)
{
	ulong id;
	
	lock (_gate)
	{
		id = unchecked(++_latest);
		_hasLatest = true;
	}

	var innerObserver = new InnerObserver(this, id);

	_innerSerialDisposable.Disposable = innerObserver;
	innerObserver.SetResource(value.SubscribeSafe(innerObserver));
}