Fix PURL test failures, migrate cyclonedx-bom to purl crate
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructor Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
…just use the `purl` crate. Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
… for us Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
|
Thank you for this. It looks good to me. Should phylum-dev/purl#11 be closed if it's handled now? |
|
Good point, I closed the upstream issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo cyclonedxDrop our custom percent encoding machinery now that the
purlcrate implements this for us. This was one hell of a rabbit hole, and it is a testament to the quality of thepurlcrate that they are actually handling this nonsense correctly now.Fixes #745
cyclonedx-bomMigrate from the very incomplete
packageurlto thepurlcrate already used bycargo cyclonedx. We used to have two different PURL crates in the tree, this brings the number back to one. Also provide a more informative error message on validation errors.Fixes #636
This is all still semver-compatible, because the
packageurlcrate was never actually exposed to the outside world. But this is a PR against main because I cannot be bothered to backport this.