Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the drop of superfluous dependencies pulled in by jsonschema #744

Conversation

Shnatsel
Copy link
Contributor

#743 but against cyclonedx-bom v0.6.1, prior to the semver-breaking changes in main.

Includes a new patch release w/ version bump and changelog.

@Shnatsel Shnatsel requested a review from a team as a code owner July 16, 2024 07:05
… a whole lot of unnecessary dependencies

Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel Shnatsel force-pushed the cyclonedx-bom-backport-for-review branch from 1b74a52 to d442277 Compare July 16, 2024 07:11
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Copy link
Contributor Author

I think Codacy just fails to analyze PRs that are not made against the main branch.

We have never seen it fail before, or ever surface a useful error, and frankly I have no idea what it's even supposed to do in the first place. I'm going to go ahead and ignore its failure here.

@Shnatsel Shnatsel merged commit 07a4585 into CycloneDX:cyclonedx-bom-backport Jul 16, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants