Drop superfluous dependencies pulled in by jsonschema
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Shnatsel
force-pushed
the
trim-jsonschema-deps
branch
from
8f7ba9c
to
39de512
Compare
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
|
Wait, nevermind, we already have non-semver-compatible changes in master. I'll have to do a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonschema's default features transitively pulled inreqwestand the entire underlying stack withmio,tokio, and a whole lot of other networking dependencies. We shouldn't have pulled in any of it in the first place, since JSON schemas are only used in tests, and we especially don't need any of its networking functionality.#740 appears to have stalled, so splitting this into its own PR to expedite things.
This does not fully address #741, but gets rid of the most egregious bloat. This is a semver-compatible change that we can ship immediately.