V24.2.0 #5
V24.2.0 #5
Conversation
| @@ -259,30 +266,12 @@ | |||
| <externally-managed-flag>false</externally-managed-flag> | |||
| <default-value>false</default-value> | |||
| </attribute-definition> | |||
| <attribute-definition attribute-id="Cybersource_CruiseApiKey"> | |||
There was a problem hiding this comment.
Ya'll removed these cruise definitions from the system-objects (ie here)
You removed them from cartridges/int_cybs_sfra_base/cartridge/configuration/preferences/customPreferences.js
but did not update:
cartridges/int_cybs_sfra_base/cartridge/configuration/index.js
which still has code like:
payerAuthenticationCruiseAPIKey: config.payerAuthenticationCruiseAPIKey || customPreferences.PayerAuthentication.Preferences.CruiseAPIKey.getValue(),
And that's causing some null pointer issues on a clean system
A system w/ a previously installed version of this cartridge will work because this system object definition will still be there Edited to strike this statement, it is not correct. The current code will not run at all, period, because the config structure will have missing/undefined elements.
| } | ||
| } | ||
| if (order.paymentInstruments[0].paymentMethod === 'CREDIT_CARD') { | ||
| if (dw.system.Site.getCurrent().getCustomPreferenceValue('Cybersource_CreditCardTransactionType').value === 'sale' ){ |
There was a problem hiding this comment.
The configuration value inside:
link_cybersource\metadata\payments_metadata\meta\Core.xml
is defined as Cybersource_CardTransactionType and not Cybersource_CreditCardTransactionType
Code and documentation changes for v24.2.0