Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Not following pagination #17

Closed
evenevan opened this issue Apr 30, 2024 · 2 comments
Closed

[Bug]: Not following pagination #17

evenevan opened this issue Apr 30, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@evenevan
Copy link

What is this bug about?

I have more than 20 mail routing rules, and it seems that the extension doesn't interact with the paginated responses of Cloudflare's API to get more.

Steps to reproduce

Replicated on MailFlare v1.4.1

Have more than 20 email routing rules. The extension won't show more than 20 email forwarding rules.

Here is what the /zones/{zone_identifier}/email/routing/rules endpoint gives for me.

{
  "result": [...],
  "success": true,
  "errors": [],
  "messages": [],
  "result_info": {
    "page": 1,
    "per_page": 20,
    "count": 20,
    "total_count": 48
  }
}

Additional info

The zone and destination address endpoints also have the same pagination issue, although I would imagine very few people hit those limits.

@evenevan evenevan added the bug Something isn't working label Apr 30, 2024
@Curetix Curetix closed this as completed in dfd8909 May 1, 2024
@Curetix
Copy link
Owner

Curetix commented May 1, 2024

Good catch! I increased the items per page to the max value of 50 and added a way to paginate through all available pages. Let me know if encounter any other issues.

@evenevan
Copy link
Author

evenevan commented May 1, 2024

Awesome! Fix seems to work great. Thanks for all your hard work and this great extension :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants