Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate Label validation error is misleading #1554

Closed
chipshort opened this issue Aug 14, 2023 · 0 comments · Fixed by #1555
Closed

Instantiate Label validation error is misleading #1554

chipshort opened this issue Aug 14, 2023 · 0 comments · Fixed by #1555
Assignees
Milestone

Comments

@chipshort
Copy link
Collaborator

When the instantiate msg's label is validated, the error it returns is thrown away and instead a "label is required" is thrown.
This is confusing for the contract author, since they provided a label, but an invalid one, with no indication of what is wrong with it. This is the case for Instantiate, Instantiate2 and StoreAndInstantiate.

I think the error from ValidateLabel should be wrapped / returned instead.

Original issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants