Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal_id field to VoteInfo structure #647

Closed
ueco-jb opened this issue Feb 4, 2022 · 0 comments · Fixed by #648
Closed

Add proposal_id field to VoteInfo structure #647

ueco-jb opened this issue Feb 4, 2022 · 0 comments · Fixed by #648
Assignees
@ueco-jb
Labels
breaking Breaking changes

Comments

@ueco-jb
Copy link
Contributor

ueco-jb commented Feb 4, 2022 •
edited
Loading

https://github.com/CosmWasm/cw-plus/blob/main/packages/cw3/src/query.rs#L101-L105

Info about vote without proposal's context makes little sense, and adding it is really easy.
Also it will be usefull in implementing list_votes_by_voters query, which lists all votes for given voter: check confio/poe-contracts#78
@ueco-jb ueco-jb added the breaking Breaking changes label Feb 4, 2022
@ueco-jb ueco-jb self-assigned this Feb 4, 2022
@ueco-jb ueco-jb mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ueco-jb ueco-jb

Labels
breaking Breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CW3: Add proposal_id field to VoteInfo structure CosmWasm/cw-plus
1 participant
@ueco-jb