Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url as input when mint cw1155 #449

Closed
ALPAC-4 opened this issue Sep 23, 2021 · 8 comments
Closed

Add url as input when mint cw1155 #449

ALPAC-4 opened this issue Sep 23, 2021 · 8 comments

Comments

@ALPAC-4
Copy link

ALPAC-4 commented Sep 23, 2021

There are no way to put url in cw1155 at the base code but the query that call url is exist.

Cw1155QueryMsg::TokenInfo { token_id } => {
    let url = TOKENS.load(deps.storage, &token_id)?;
    to_binary(&TokenInfoResponse { url })
}

So I think adding url as input at excute_mint function is reasonable.

@ethanfrey
Copy link
Member

Is this for an NFT project?

Can you check out the brand new https://github.com/CosmWasm/cw-nfts repo?

We are trying to move all not related work there. If cw1155 work is primarily about NFTs, then maybe we can move that over as well.

@ALPAC-4
Copy link
Author

ALPAC-4 commented Sep 28, 2021

I know some projects that using ERC1155 for NFT (like SAND).
And currently I'm doing some research about NFT for some reasons.
That's why I also look into CW1155.

The purpose of the opening issue was just curious that why there is the queryMsg that call url, even there are no way to put in.

And good to hear about the cw-nfts repo. It just a personal opinion but CW1155 can be in there too.

@ethanfrey
Copy link
Member

@yihuang wrote cw1155 contract I believe. Maybe he can answer. And also discuss if he wishes to move it to cw-nfts

@yihuang
Copy link
Contributor

yihuang commented Sep 28, 2021

Yeah, I guess either set URL when mint or a dedicated message to manage the metadata URL is fine, no strong opinions on that.

@ethanfrey
Copy link
Member

@ALPAC-4 do you want to make a PR for this change? To add metadata url on mint?

We can discuss moving repos after the next release

@JakeHartnell
Copy link

@yihuang wrote cw1155 contract I believe. Maybe he can answer. And also discuss if he wishes to move it to cw-nfts

Once we feel good about the base cw721 contract, we're definitely going to be working on cw1155.

@ALPAC-4
Copy link
Author

ALPAC-4 commented Oct 1, 2021

@yihuang wrote cw1155 contract I believe. Maybe he can answer. And also discuss if he wishes to move it to cw-nfts

Once we feel good about the base cw721 contract, we're definitely going to be working on cw1155.

Thanks for all your effort. I'm not a RUST dev. (I can just read some code) So I'll waiting for you. Thanks a lot

@ethanfrey
Copy link
Member

I'm closing this here.

@JakeHartnell is taking this over in cw-nfts repo (linked above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants