Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make message required in Cw20ReceiveMsg #283

Closed
ethanfrey opened this issue Apr 21, 2021 · 0 comments · Fixed by #286
Closed

Make message required in Cw20ReceiveMsg #283

ethanfrey opened this issue Apr 21, 2021 · 0 comments · Fixed by #286
Assignees
@maurolacy
Milestone
0.6.0

Comments

@ethanfrey
Copy link
Member

It is defined as Option<Binary>, but we always use Some(...).
There is no reason not to send one and this only makes confusion as came up with the cw1155 design.

Let's just make msg: Binary and update the apps to use it. (It is JSON compatible for all those who send with values)
@ethanfrey ethanfrey added this to the 0.6.0 milestone Apr 21, 2021
@maurolacy maurolacy self-assigned this Apr 26, 2021
@maurolacy maurolacy mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Cw20ReceiveMsg msg field CosmWasm/cw-plus
2 participants
@ethanfrey @maurolacy