Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep-Alive ignored within Service error handling. #28

Closed
ben-crowhurst opened this issue Aug 23, 2015 · 2 comments
Closed

Keep-Alive ignored within Service error handling. #28

ben-crowhurst opened this issue Aug 23, 2015 · 2 comments
Assignees
Milestone

Comments

@ben-crowhurst
Copy link
Member

We don't check for 'Connection: keep-alive' before calling close on 404, 501, and 500 error logic.

@ben-crowhurst ben-crowhurst added this to the 3.5 milestone Aug 24, 2015
@ben-crowhurst ben-crowhurst modified the milestones: 4.0, 3.5 Sep 25, 2015
@ben-crowhurst
Copy link
Member Author

This can't be properly tested until we have a more flexible HTTP client, see issue #41.

@ben-crowhurst
Copy link
Member Author

The default service/resource fault handler has been designed to perform as little work as possible. This decision was made to reduce the likelihood of causing additional error conditions and mudding up the water. Users are free to set their own error handlers via Service::set_error_handler/Resource::set_error_handler if they do not agree with this decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant