From d11af9e3a1fbfb15c3b23ccfdeb894f1b46faf18 Mon Sep 17 00:00:00 2001 From: Dzmitry Hil Date: Tue, 5 Mar 2024 13:43:05 +0300 Subject: [PATCH] Fix misspellings and code duplication (#181) --- relayer/client/bridge.go | 7 +++---- relayer/cmd/cli/cli.go | 2 +- relayer/runner/runner.go | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/relayer/client/bridge.go b/relayer/client/bridge.go index 3227f4fd..a7546a58 100644 --- a/relayer/client/bridge.go +++ b/relayer/client/bridge.go @@ -453,7 +453,6 @@ func (b *BridgeClient) RegisterXRPLToken( zap.String("currency", stringCurrency), zap.Int32("sendingPrecision", sendingPrecision), zap.String("maxHoldingAmount", maxHoldingAmount.String()), - zap.String("maxHoldingAmount", maxHoldingAmount.String()), zap.String("bridgingFee", bridgingFee.String()), ) txRes, err := b.contractClient.RegisterXRPLToken( @@ -1063,7 +1062,7 @@ func (b *BridgeClient) validateXRPLBridgeAccountBalance( ctx context.Context, xrplBridgeAccount rippledata.Account, ) error { - requiredXRPLBalance := ComputeXRPLBrideAccountBalance() + requiredXRPLBalance := ComputeXRPLBridgeAccountBalance() b.log.Info( ctx, "Compute required XRPL bridge account balance to init the account", @@ -1134,8 +1133,8 @@ func (b *BridgeClient) setUpXRPLBridgeAccount( return b.autoFillSignSubmitAndAwaitXRPLTx(ctx, &disableMasterKeyTx, bridgeAccountKeyName) } -// ComputeXRPLBrideAccountBalance computes the min balance required by the XRPL bridge account. -func ComputeXRPLBrideAccountBalance() float64 { +// ComputeXRPLBridgeAccountBalance computes the min balance required by the XRPL bridge account. +func ComputeXRPLBridgeAccountBalance() float64 { return minBalanceToCoverFeeAndTrustLines + xrpl.ReserveToActivateAccount + // one additional item reserve is needed for a signer list object for multisig. diff --git a/relayer/cmd/cli/cli.go b/relayer/cmd/cli/cli.go index dd12fb05..d076ec1d 100644 --- a/relayer/cmd/cli/cli.go +++ b/relayer/cmd/cli/cli.go @@ -539,7 +539,7 @@ $ bootstrap-bridge bootstrapping.yaml --%s bridge-account return errors.Wrapf(err, "failed to get %s", FlagRelayersCount) } if relayersCount > 0 { - minXrplBridgeBalance := bridgeclient.ComputeXRPLBrideAccountBalance() + minXrplBridgeBalance := bridgeclient.ComputeXRPLBridgeAccountBalance() components.Log.Info(ctx, "Computed minimum XRPL bridge balance", zap.Float64("balance", minXrplBridgeBalance)) } diff --git a/relayer/runner/runner.go b/relayer/runner/runner.go index c3f96303..fe2b1a19 100644 --- a/relayer/runner/runner.go +++ b/relayer/runner/runner.go @@ -70,7 +70,7 @@ func NewRunner(ctx context.Context, components Components, cfg Config) (*Runner, contractConfig, err := components.CoreumContractClient.GetContractConfig(ctx) if err != nil { - return nil, errors.Wrapf(err, "failed to get contract config for the runner intialization") + return nil, errors.Wrapf(err, "failed to get contract config for the runner initialization") } bridgeXRPLAddress, err := rippledata.NewAccountFromAddress(contractConfig.BridgeXRPLAddress)