Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Eth2Peer interface #6872

Closed
mehdi-aouadi opened this issue Feb 27, 2023 · 0 comments
Closed

Refactor the Eth2Peer interface #6872

mehdi-aouadi opened this issue Feb 27, 2023 · 0 comments

Comments

@mehdi-aouadi
Copy link
Contributor

See #6835 (comment) for more details

wantToMakeRequest could be renamed to peerRateLimitReached and wantToReceiveBlobSidecars to blobSidecarsRequestsLimitReached.

the two calls could also be encapsulated in a private method: doesTriggerRateLimit(callback, maxRequestSize.min(message.getCount()).longValue()))
@mehdi-aouadi mehdi-aouadi mentioned this issue Feb 27, 2023
Merged
2 tasks
@benjaminion benjaminion changed the title Refactor the Eth2Perr interface Refactor the Eth2Peer interface Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehdi-aouadi @benjaminion