Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit rate limiting of blobs sidecars #6788

Closed
StefanBratanov opened this issue Feb 8, 2023 · 0 comments
Closed

Revisit rate limiting of blobs sidecars #6788

StefanBratanov opened this issue Feb 8, 2023 · 0 comments
Assignees
@mehdi-aouadi
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Feb 8, 2023 •
edited
Loading

There are issues while syncing related to rate limiting of blobs sidecars. It is related to #6767

  • We rate limit "in advance" on wantToReceiveBlobsSidecars so we do not consider if there are empty blobs sidecar in the batch. To be evaluated, the PR in spec says "MAY".
  • Related to the first point. we may want to consider applying the rate limit only from the responses we get from the peer rather than in advance.
  • Revisit the different RateTrackers for blocks and blobs. Do we want one or multiple, change the number of accepted requests, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehdi-aouadi mehdi-aouadi

Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehdi-aouadi @StefanBratanov