Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Attestation Inclusion Criteria in Per-Block Processing Logic - (Spec PR #752) #482

Closed
schroedingerscode opened this issue Mar 15, 2019 · 1 comment
Closed

Tweak Attestation Inclusion Criteria in Per-Block Processing Logic - (Spec PR #752) #482

schroedingerscode opened this issue Mar 15, 2019 · 1 comment
Assignees
@akhila-raju
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want to include any attestation whose slot is >= to the genesis slot AND whose slot is no more than one epoch (inclusive) of the current state so that all valid attestations may be included.

Acceptance Criteria

  • During the processAttestations step of per-block processing, any attestation such that state.slot <= attestation.slot.data + SLOTS_PER_EPOCH should be included.

Additional Information

See ethereum/consensus-specs#752
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Mar 15, 2019
@schroedingerscode schroedingerscode added this to the Beacon Chain v0.5.0 Spec milestone Mar 15, 2019
@schroedingerscode schroedingerscode changed the title - (Spec PR #752) Fix Attestation Inclusion Criteria in Per-Block Processing Logic - (Spec PR #752) Mar 15, 2019
@schroedingerscode schroedingerscode changed the title Fix Attestation Inclusion Criteria in Per-Block Processing Logic - (Spec PR #752) Tweak Attestation Inclusion Criteria in Per-Block Processing Logic - (Spec PR #752) Mar 15, 2019
@akhila-raju
Copy link
Contributor

Already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akhila-raju akhila-raju

Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhila-raju @schroedingerscode