Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch Transition at Start of Epoch - (Spec PR #732, #741) #473

Closed
schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Closed

Epoch Transition at Start of Epoch - (Spec PR #732, #741) #473

schroedingerscode opened this issue Mar 15, 2019 · 0 comments
Assignees
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want to transition epochs at the start of the epoch instead of during the last slot of the epoch, so that off-by-one issues related to transition helpers functions and verification are mitigated.

Acceptance Criteria

  • Transition logic is reordered as defined in 732 linked below.
  • Remove off-by-one kludge during attestation processing in the per-block processing logic.
  • Cache block root in initial state cache to ensure that block root of previous slot is available for epoch processing.
  • Remove setting state_root during advance_slot portion of per-epoch processing.

Additional Information

See ethereum/consensus-specs#732
See ethereum/consensus-specs#741

@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Mar 15, 2019
@schroedingerscode schroedingerscode added this to the Beacon Chain v0.5.0 Spec milestone Mar 15, 2019
@akhila-raju akhila-raju self-assigned this Mar 18, 2019
@akhila-raju akhila-raju removed their assignment Mar 28, 2019
@cemozerr cemozerr self-assigned this Apr 1, 2019
@jrhea jrhea closed this as completed May 8, 2019
@jrhea jrhea mentioned this issue May 8, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants