Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BeaconState to match 0.4 spec (mostly renamings) #444

Closed
benjaminion opened this issue Mar 8, 2019 · 1 comment
Closed

Update BeaconState to match 0.4 spec (mostly renamings) #444

benjaminion opened this issue Mar 8, 2019 · 1 comment
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@benjaminion
Copy link
Contributor

benjaminion commented Mar 8, 2019 •
edited
Loading

Description

As a developer, I want state variables to match the latest specification so that implementing the spec is not confusing.

Acceptance Criteria

  • State variables match the 0.4 spec and names are correct
  • Getters and setters are correctly renamed throughout the code

Other information

  • previous_epoch_start_shard -> previous_shuffling_start_shard
  • current_epoch_start_shard -> current_shuffling_start_shard
  • previous_calculation_epoch -> previous_shuffling_epoch
  • current_calculation_epoch -> current_shuffling_epoch
  • previous_epoch_seed -> previous_shuffling_seed
  • current_epoch_seed -> current_shuffling_seed
  • latest_index_roots -> latest_active_index_roots
  • latest_penalized_balances -> latest_slashed_balances
  • deposit_index -> new (should be dealt with in Skip Invalid Deposits, Add Deposit Index Ordering - (Spec PR #589, #594) #404)
@benjaminion benjaminion added the enhancement 🕵️‍♀️ New feature or request label Mar 8, 2019
@benjaminion benjaminion added this to the Beacon Chain v0.4.0 Spec milestone Mar 8, 2019
@benjaminion benjaminion added good first issue 🙋 This is a good first issue for a new contributor to work on in progress 🚧 This issue or pull request is in progress and removed good first issue 🙋 This is a good first issue for a new contributor to work on labels Mar 8, 2019
@benjaminion benjaminion mentioned this issue Mar 9, 2019
Merged
@benjaminion
Copy link
Contributor Author

Closed by #450

@benjaminion benjaminion removed the in progress 🚧 This issue or pull request is in progress label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@benjaminion