Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity Issue on "ResponesError" with Ruby 1.9.3 #17

Open
thinkinginmath opened this issue Dec 18, 2013 · 1 comment
Open

Compatiblity Issue on "ResponesError" with Ruby 1.9.3 #17

thinkinginmath opened this issue Dec 18, 2013 · 1 comment

Comments

@thinkinginmath
Copy link

I ran into this run time error,

net/imap.rb:3480:in initialize': undefined methoddata' for "Unexpected continuation response from server":String (NoMethodError)
from em-imap-0.5/lib/em-imap/continuation_synchronisation.rb:66:in `new'

In Ruby 1.9, class ResponseError is changed. The constructor takes an response other than an arbitrary error string.

Is there a plan to make this library compatible with 1.9?

Also, what is the typical way of a ruby gem to support both 1.8.7 and 1.9?

@ConradIrwin
Copy link
Owner

The easiest solution in our case is probably to make it work with the 1.9.3 version of Net::IMAP, and ignore 1.8. If you want to spend more time, then we could copy one version of Net::IMAP into em-imap under a different name; or just add runtime switches so that it handles both correctly.

I'm not a huge fan of the Net::IMAP parser, so maybe eventually it'll go away completely — it's pretty awesome for what it does though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants