Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): facebook and google native login missing scopes #887

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

kkopanidis
Copy link
Contributor

fix(authentication): native login expecting clientId in request params
fix(authentication): native login not using scope conditionally from params

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

fix(authentication): native login expecting clientId in request params
fix(authentication): native login not using scope conditionally from params
@kkopanidis kkopanidis merged commit 470798e into main Jan 11, 2024
4 checks passed
@kkopanidis kkopanidis deleted the authentication/oauth branch January 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants