Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database): add cnd_ prefix check for collectionName #570

Merged
merged 2 commits into from
Mar 24, 2023
Merged

fix(database): add cnd_ prefix check for collectionName #570

merged 2 commits into from
Mar 24, 2023

Conversation

ChrisPdgn
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

kon14
kon14 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@kon14 kon14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd be checking whether operation is related to schema import, but I guess nobody's gonna prefix schemas with cnd_ anyway.

@kkopanidis kkopanidis merged commit 641bcb6 into main Mar 24, 2023
@kkopanidis kkopanidis deleted the fix-import-export branch March 24, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon14 kon14 kon14 approved these changes

@kkopanidis kkopanidis kkopanidis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisPdgn @kon14 @kkopanidis