Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authentication): OAuth2 authentication url construction #482

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Jan 5, 2023

This PR fixes the following issues in regards to OAuth2 authentication url construction:

  • code_challenge and code_challenge_method passed as undefined when not explicitly used by provider
  • activation url query params not being prefixed by ?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

@kkopanidis kkopanidis merged commit eae1e82 into main Jan 5, 2023
@kkopanidis kkopanidis deleted the fix-oauth2 branch January 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants