Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc-sdk,admin): config object patch array field merging #464

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Dec 8, 2022

This PR fixes config object patches, where array fields would previously get merged.

Previously patching { a: true, b: [1, 2, 3] } with { b: [3] } resulted in { a: false, b: [3, 2, 3] }.
With fix, the above patch results in { a: true, b: [3] }.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants