feat(database,grpc-sdk)!: compiled schema fields as gRPC schema type fields #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(database): publishSchema bus call using wrong fields field name refactor(database,grpc-sdk)!: clean up schema extension gRPC types BREAKING CHANGE: Database protofile update. Custom microservices should simply upgrade to their grpc-sdk.
Fixes a bug introduced earlier today (8d5471b) where schema stitching would take place too early for gRPC scheam creation requests.
kkopanidis
approved these changes
Sep 5, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that all
DatabasegRPC schema type responses return the compiled schema fields (base fields + extension fields) infields.I'm converting these schema types in a util atm, but once the schema types are finally properly typed we could make this a schema class method or getter instead.
I also cleaned up db proto types around schema extensions and whatnot.
Fixed an outdated schema
fieldsfield name reference in apublishSchema()call.Fixed a bug introduced earlier today (
8d5471b8) that resulted in schema stitching taking place before extension merging in gRPC schema recreation.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Cleaned up the
Database's proto file.This should only affect custom microservices.
Simply upgrading to the latest version of
grpc-sdkshould suffice.The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: