fix(database): gRPC schema registration removing schema extensions from adapter models #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where incoming gRPC schema registrations would remove a schema's extensions from its adapter model, effectively dropping its extensions until the
Database
gets restarted and the adapters repopulated with the contents ofDeclaredSchema
.To reproduce:
Core
Database
and set an extension increateSchemaFromAdapter()
(or similar)DeclaredSchemas
list their extensions as expectedI'm using a hacky type any cast for the schema object as the schema types are already messed up to the point where it wouldn't be worth attempting to retype this on the spot.
We'll have to clean these up properly.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)