feat(database): db engine connection attempts during startup #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kon14
requested changes
Jul 6, 2022
kon14
changed the title
|
Actually, let's also make the timeout duration consistent between Mongoose and Sequelize and display a connection attempt message in Mongoose. |
chore(database): db engine connection logs Database engine initial connection timeout may now be configured via specifying desired ms in MAX_CONN_TIMEOUT_MS env var.
kon14
approved these changes
Jul 7, 2022
kkopanidis
requested changes
Jul 7, 2022
|
This needs to be rebased against Mongoose updates from |
kkopanidis
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds support for multiple connection attempts in the Sequelize adapter in case connection fails.
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: