-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual attributes for different species #614
Comments
I am against coreCharge, |
after discussions today, we decided to rather store the # of bound electrons instead of the charge state (since it is easier to be expanded to electron configurations later on). |
Should it still be float like you suggested with |
yes, it's not super-obvious in the first place but likely to be useful in the future. |
I already have one branch ready for |
The only thing left in this issue is automatic memory assignment based on how many particles may exist during the simulation, not only before. But that could be handled later, separately. |
sounds great, do you want to open a fresh issue for that (with a longer description of the memory assignment task)? |
Yeah, I'd rather do that. |
While implementing Ionization in PIConGPU it became obvious that the attribute
chargeState
will not be sufficient in the future. For precise information especially on ion species it will become necessary to introduce another independent attribute:coreCharge
orprotonNumber
ormaxNumOfElectrons
That way it will be clear if the species is e.g. Hydrogen or Carbon. Also it will be very native with respect to the underlying physics.
The issue #108 already suggested that e.g. plugins should be able to activate specific attributes. Ideally though, some attributes shouldn't even exist for some species. Setting a
coreCharge
for each electron does not only look like a waste of memory on a first glance but with the run time creation of electrons in #595 one might encounter more serious memory problems.It should therefore be possible to assign attributes differently for different species. Memory should also be dedicated to that species accordingly and maybe even automatically.
Example
The text was updated successfully, but these errors were encountered: