Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: ZLIB Deps #283

Open
ax3l opened this issue Mar 1, 2019 · 0 comments
Open

CMake: ZLIB Deps #283

ax3l opened this issue Mar 1, 2019 · 0 comments

Comments

@ax3l
Copy link
Member

ax3l commented Mar 1, 2019

We currently (1.7.0) link in CMakeLists.txt to ZLIB::ZLIB, although we do not include zlib directly in Splash.

This dependency should nowadays (recent CMake versions such as our 3.10+) be properly be pulled by the HDF5 CMake target.

Currently, we request zlib again and forget to search it in SplashConfig.cmake, which leads to the downstream issue of injecting a ZLIB::ZLIB in Splash::Splash yet not looking for a target. Therefore, users have to perform

find_package(ZLIB REQUIRED)
# just to get the ZLIB::ZLIB target into scope
# otherwise `Splash::Splash` below tries to link `-lZLIB::ZLIB`

find_package(Splash REQUIRED)
target_link_libraries(myTarget PRIVATE Splash::Splash)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant