New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ContainerInstance environment variables from anonymous records to ADT #372

Closed

jjguijt opened this issue Sep 22, 2020 · 1 comment

Labels

jjguijt commented Sep 22, 2020

Environment variables for containers currently use anonymous records. I think this should be changed to an algebraic data type, because:

Arguably, the code is more clear.
Not using anonymous records enables interop from C# (which is important for my use case)

The proposed changes are in #371

Please let me know if there is a better solution.

jjguijt mentioned this issue

Change environment variables from anonymous type to ADT #371

Merged

isaacabraham added the enhancement label

Member

isaacabraham commented Sep 23, 2020

Sounds good.

isaacabraham closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment