Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the TokenizingTextBox control behaviours for initial commit #3247

Merged
merged 18 commits into from
May 16, 2020

Conversation

marcpems
Copy link
Contributor

@marcpems marcpems commented Apr 22, 2020

Fixes #195, #3057

Add the TokenizingTextBox control and sample page

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

None

What is the new behavior?

Add the tokenizing text box that allows selection of items from a list to be populated in a wrapped panel of items with a text filter entry in the list.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Apr 22, 2020

Thanks marcpems for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcpems Thanks for the PR. When I was testing the Tokenizingtextbox I noticed that when I select an option from the Action dropdown list, the name also seems to appear next to the selected item. Then I have to manually delete the name to select another item from the list. Also when I try to delete the selected Items with the Backspace button, it deletes two items instead of one. The Backspace button problem also seems to be consistent in the "Select Email Addresses" area as well. You can see that in the Gif mentioned below.

BackspaceError

@marcpems
Copy link
Contributor Author

@marcpems Thanks for the PR. When I was testing the Tokenizingtextbox I noticed that when I select an option from the Action dropdown list, the name also seems to appear next to the selected item. Then I have to manually delete the name to select another item from the list. Also when I try to delete the selected Items with the Backspace button, it deletes two items instead of one. The Backspace button problem also seems to be consistent in the "Select Email Addresses" area as well. You can see that in the Gif mentioned below.

BackspaceError

should now be resolved. Thanks for highlighting this.

@Kyaa-dost
Copy link
Contributor

@marcpems Thanks for fixing that and it looks great. I ran into another issue. When I type a letter or a word in the "Add Actions" area it seems like some of the items in the drop-down list appear quicker and some not.

Here is a Gif that displays the behavior.
TokenizingTextbox

removed redundant space from cut / copy text.
shift + arrow navigation bug fixed.
@marcpems
Copy link
Contributor Author

dd Actions

If I understand the issue you are highlighting, I think this is linked to the animation used when an item is added to the suggestion list, right?
I'll take a look at how that can be customized...

@azchohfi
Copy link
Contributor

azchohfi commented May 2, 2020

@marcpems
TokenizingTextBox\TokenizingTextBoxItem.cs(25,22): error SA1306: Field 'IsClick' should begin with lower-case letter

@michael-hawker
Copy link
Member

Thanks @azchohfi, I'm the process of restructuring somethings for the control, so I'll run a local build after I do a merge and catch any of those before we update this PR. :)

@michael-hawker michael-hawker added this to the 6.1 milestone May 15, 2020
Unmoved files from merge - project moved
@michael-hawker
Copy link
Member

michael-hawker commented May 16, 2020

@marcpems the only two issues I've noticed in the porting are that the Email List example isn't showing the e-mails in the ListView in release mode for some reason, no clue what's going on there. (The base control is working fine).

Also the padding is off, the textbox is stretching the box down so there's space below the tokens. Not sure why this is appearing different than our other test environment. I'm going to get this in so we can have a MyGet for folks to test with and we'll follow these up as bugs next week.

Called these out in #3289.

@michael-hawker michael-hawker merged commit 81975b0 into master May 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the marcpe/TokenizeTextBox branch May 16, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New control: AutoSuggestBox that allows snapping of resolved items
4 participants