-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the TokenizingTextBox control behaviours for initial commit #3247
Conversation
Thanks marcpems for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcpems Thanks for the PR. When I was testing the Tokenizingtextbox I noticed that when I select an option from the Action dropdown list, the name also seems to appear next to the selected item. Then I have to manually delete the name to select another item from the list. Also when I try to delete the selected Items with the Backspace button, it deletes two items instead of one. The Backspace button problem also seems to be consistent in the "Select Email Addresses" area as well. You can see that in the Gif mentioned below.
… the selected text is left in the text box
should now be resolved. Thanks for highlighting this. |
@marcpems Thanks for fixing that and it looks great. I ran into another issue. When I type a letter or a word in the "Add Actions" area it seems like some of the items in the drop-down list appear quicker and some not. |
removed redundant space from cut / copy text. shift + arrow navigation bug fixed.
If I understand the issue you are highlighting, I think this is linked to the animation used when an item is added to the suggestion list, right? |
…n other parts of the control
@marcpems |
Thanks @azchohfi, I'm the process of restructuring somethings for the control, so I'll run a local build after I do a merge and catch any of those before we update this PR. :) |
Remove unused DataTemplate Selector
# Conflicts: # UnitTests/UnitTests.UWP/UnitTests.UWP.csproj
Unmoved files from merge - project moved
@marcpems the only two issues I've noticed in the porting are that the Email List example isn't showing the e-mails in the ListView in release mode for some reason, no clue what's going on there. (The base control is working fine). Also the padding is off, the textbox is stretching the box down so there's space below the tokens. Not sure why this is appearing different than our other test environment. I'm going to get this in so we can have a MyGet for folks to test with and we'll follow these up as bugs next week. Called these out in #3289. |
Fixes #195, #3057
Add the TokenizingTextBox control and sample page
PR Type
What kind of change does this PR introduce?
What is the current behavior?
None
What is the new behavior?
Add the tokenizing text box that allows selection of items from a list to be populated in a wrapped panel of items with a text filter entry in the list.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information