#3210 Add GazeInput.SetCursorBrush method #3221
Conversation
…he default GazeCursor color
|
Thanks deanchalk for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
There was a problem hiding this comment.
Thanks, @deanchalk! The sample app is featuring a new color picker option with accessibility to pick any color for the cursor.
|
I have a gaze tracker I can setup and try this out with. @niels9001 is the improved sample here sufficient for now, or would you still like to see a method exposed? I guess I'm asking if we should leave the issue open or if it could be closed with this improved sample? |
|
Yeah I think this resolves the issue (and provides even more functionality!). Can we add the showcased APIs as a refernce in the docs? |
|
We'll look at this on Monday as we can update after CC as we finish getting the Sample App build together for the 6.1 release. |
| private void ResetGazeCursor() | ||
| { | ||
| var size = GazeInput.GetCursorRadius(gazePointer.CursorElement); | ||
| gazePointer.CursorElement = new Ellipse |
There was a problem hiding this comment.
I got an exception right here testing this, when I clicked on the "Open/Close Color Selector" button.
System.Exception
HResult=0x800F1000
Message=No installed components were detected.
Child collection must not be modified during measure or arrange.
Source=<Cannot evaluate the exception source>
StackTrace:
<Cannot evaluate the exception stack trace>
Here is the stack:
[Managed to Native Transition]
> Microsoft.Toolkit.Uwp.SampleApp.exe!Microsoft.Toolkit.Uwp.SampleApp.SamplePages.GazeInteractionPage.ResetGazeCursor() Line 69 C#
Microsoft.Toolkit.Uwp.SampleApp.exe!Microsoft.Toolkit.Uwp.SampleApp.SamplePages.GazeInteractionPage.SelectedColor.set(Windows.UI.Color value) Line 93 C#
Microsoft.Toolkit.Uwp.SampleApp.exe!Microsoft.Toolkit.Uwp.SampleApp.SamplePages.GazeInteractionPage.GazeInteractionPage_obj1_Bindings.UpdateTwoWay_13_Color() Line 161 C#
Microsoft.Toolkit.Uwp.SampleApp.exe!Microsoft.Toolkit.Uwp.SampleApp.SamplePages.GazeInteractionPage.GazeInteractionPage_obj1_Bindings.GazeInteractionPage_obj1_BindingsTracking.RegisterTwoWayListener_13.AnonymousMethod__4_0(Windows.UI.Xaml.DependencyObject sender, Windows.UI.Xaml.DependencyProperty prop) Line 203 C#
|
Moving out to 7.0. @azchohfi you were playing with writing the Gaze helpers in C# no? We should talk about if we want to do that conversion for 7.0 too. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
|
@deanchalk any update? ⬆️ |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
Kyaa-dost
added
feature 💡
and removed
feature request 📬
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
|
@deanchalk haven't heard from you for a long time. Hope everything is well! If you get a chance please let us know of any updates. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
|
Moving to 7.1 |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 30 days of this comment. |
|
Close for now until we hear back more from @deanchalk about if he'd like to continue this. This was before our move from C++ to C# I believe, so there may be more opportunities to make improvements more easily now moving forward. |
Fixes #3210
The GazeInteraction c++ code hard-codes a cursor with an IndianRed ellipse. I have changes the sample page to allow the user to pick their own color for this
PR Type
What kind of change does this PR introduce?
Feature
Sample app changes
What is the current behavior?
The GazeCursor was fixed as an Ellipse with IndianRed fill, which doesn't always work with the users theme
What is the new behavior?
The sample page for GazeInteraction now has a color picker that allows the user to select a new cursor color.
PLEASE NOTE - I cannot test this personally, as I dont have the Eye tracking equipment necessary
PR Checklist
Please check if your PR fulfills the following requirements:
Other information