Replace Task.FromResult by Task.CompletedTask

[vgromfeld]

PR Type

What kind of change does this PR introduce?

• Refactoring (no functional changes, no api changes)

What is the current behavior?

The community toolkit code is using Task.FromResult(0) to create completed task. This is not needed since we can directly use Task.CompletedTask and spare a few allocations.

What is the new behavior?

The Task.CompletedTask instance will now be used for async methods returning a completed task.

PR Checklist

• Tested code with current supported SDKs
• Pull Request has been submitted to the documentation repository instructions. Link:
• Sample in sample app has been added / updated (for bug fixes / features)
  • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
• Tests for the changes have been added (for bug fixes / features) (if applicable)
• Header has been added to all new source files (run build/UpdateHeaders.bat)
• Contains NO breaking changes

[ghost]

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

[azchohfi]

This code probably came from a .Net 4.5 equivalent, which don't have that property. Makes total sense to use CompletedTask!