Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Controls: InAppNotification smaple throws execption. #3739

Closed
1 of 2 tasks
Rosuavio opened this issue Feb 5, 2021 · 2 comments · Fixed by #3740
Closed
1 of 2 tasks

Split Controls: InAppNotification smaple throws execption. #3739

Rosuavio opened this issue Feb 5, 2021 · 2 comments · Fixed by #3740
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior needs triage 🔍
Milestone

Comments

@Rosuavio
Copy link
Contributor

Rosuavio commented Feb 5, 2021

Describe the bug

When opening the InAppNotification sample, the sample app throws an exception.

Microsoft.Toolkit.Uwp.SampleApp.exe!Microsoft.Toolkit.Uwp.SampleApp.SampleController.OnNavigatedTo(Windows.UI.Xaml.Navigation.NavigationEventArgs e) Line 232 C#

System.NotSupportedException
  HResult=0x80131515
  Message=Unrecognized short identifier 'StackMode'; Define type and parameters of property in first occurrence in InAppNotificationXaml.bind.
  Source=Microsoft.Toolkit.Uwp.SampleApp
  StackTrace:
   at Microsoft.Toolkit.Uwp.SampleApp.Sample.<PreparePropertyDescriptorAsync>d__91.MoveNext() in C:\Users\Rosario\source\repos\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.SampleApp\Models\Sample.cs:line 466
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at Microsoft.Toolkit.Uwp.SampleApp.SampleController.<OnNavigatedTo>d__14.MoveNext() in C:\Users\Rosario\source\repos\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.SampleApp\Pages\SampleController.xaml.cs:line 232

  This exception was originally thrown at this call stack:
    Microsoft.Toolkit.Uwp.SampleApp.Sample.PreparePropertyDescriptorAsync() in Sample.cs
    [External Code]
    Microsoft.Toolkit.Uwp.SampleApp.SampleController.OnNavigatedTo(Windows.UI.Xaml.Navigation.NavigationEventArgs) in SampleController.xaml.cs
  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work: dev/split-controls

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:

  1. Open InAppNotification sample in sample app
  2. Exception gets thrown

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

NuGet Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [ ] May 2020 Update (19041)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2019 (version: ) 
- [ ] 2019 Preview (version: )

Additional context

Add any other context about the problem here.

@Rosuavio Rosuavio added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 5, 2021
@ghost ghost added the needs triage 🔍 label Feb 5, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

Hello RosarioPulella, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Rosuavio
Copy link
Contributor Author

Rosuavio commented Feb 5, 2021

This is due to the LookForTypeByName (Microsoft.Toolkit.Uwp.SampleApp\Models\Sample.cs 629 29) fn not loading types in the assembly containing InAppNotification (Controls.Core). Working on a fix.

@ghost ghost added the In-PR 🚀 label Feb 5, 2021
ghost pushed a commit that referenced this issue Feb 9, 2021
#3740)

<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

<!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork.  This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->


## Fixes #3739 #3735 
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->

<!-- Add a brief overview here of the feature/bug & fix. -->
 Smaple.cs LookForTypeByName(string) add assmbiles to search in

- Microsoft.Toolkit.Uwp.UI.Controls -> Microsoft.Toolkit.Uwp.UI.Controls.Core
- Microsoft.Toolkit.Uwp.UI.Controls.Layout
- Microsoft.Toolkit.Uwp.UI.Controls.Media
- Microsoft.Toolkit.Uwp.UI.Controls.Media

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

- Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->


## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->


## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [ ] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Feb 9, 2021
@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Feb 9, 2021
@ghost ghost removed the Completed 🔥 label Feb 9, 2021
@Kyaa-dost Kyaa-dost linked a pull request Feb 9, 2021 that will close this issue
8 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior needs triage 🔍
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants