Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Rename MasterDetailsView control to ListDetailsView #3606

Closed
mrlacey opened this issue Dec 4, 2020 · 6 comments · Fixed by #3752
Closed

Proposal: Rename MasterDetailsView control to ListDetailsView #3606

mrlacey opened this issue Dec 4, 2020 · 6 comments · Fixed by #3752
Labels
good first issue Issues identified as good for first-time contributors improvements ✨ in progress 🚧 In-PR 🚀
Milestone

Comments

@mrlacey
Copy link
Contributor

mrlacey commented Dec 4, 2020

In line with efforts elsewhere to reflect more inclusive language (example), is now a good time to change the name of the MasterDetail control?

I suggest ListDetail, ListAndDetail, ListWithDetail, ListAndContent, or ListWithContent as alternatives. Suggestions welcome.

@mrlacey mrlacey added the question ❔ Issues or PR require more information label Dec 4, 2020
@ghost ghost added the needs triage 🔍 label Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

Hello mrlacey, thank you for your interest in Windows Community Toolkit!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible.. Other community members may also answer the question and provide feedback 🙌

@Rosuavio
Copy link
Contributor

Rosuavio commented Dec 4, 2020

@mrlacey Thanks for raising this issue! We have an effort to rename out the master branch to main in #3062 but we must have overlooked this.

@Rosuavio
Copy link
Contributor

Rosuavio commented Dec 4, 2020

Personally, I am leaning towards ListDetail. I feel like is just as concise as MasterDetail but more descriptive.

@Kyaa-dost
Copy link
Contributor

@mrlacey Thanks for highlighting the issue and providing suggestions!!

@michael-hawker @azchohfi thoughts on this?

@michael-hawker
Copy link
Member

Thanks @mrlacey - I thought we had an issue for this already somewhere, but guess not, thanks for filing!

We have had this on our radar though. We were waiting for official guidance on the recommended naming for this control from the design group within Microsoft. Seems like Xamarin has moved forward, so let me revive that thread as I hadn't heard back yet.

This is definitely something we should resolve for 7.0.

@RosarioPulella for the master to main branch, we've been waiting for the official GitHub tools which will help with the redirects as otherwise we'll break a bunch of folks who've cloned the repo.

@michael-hawker
Copy link
Member

michael-hawker commented Dec 7, 2020

Followed-up, seems like consensus hasn't been reached yet but some folks have continued forward, which we probably will need to do before 7.0 ships...

I think ListDetailsView is probably the best choice for now to move forward.

Eventually, we should probably update the control with some of the functionality the Apple Version has like 3 columns support and overlay support. That'll be handy too when combined with the update waiting in PR #3173. We should probably have a separate issue tracking those features.

For now we'll just rename the control for 7.0

@michael-hawker michael-hawker added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities and removed open discussion ☎️ question ❔ Issues or PR require more information labels Dec 7, 2020
@michael-hawker michael-hawker changed the title Proposal: Rename MasterDetail control Proposal: Rename MasterDetailsView control to ListDetailsView Dec 7, 2020
@Kyaa-dost Kyaa-dost linked a pull request Feb 12, 2021 that will close this issue
8 tasks
@ghost ghost removed the help wanted Issues identified as good community contribution opportunities label Feb 12, 2021
@ghost ghost added the in progress 🚧 label Feb 12, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issues identified as good for first-time contributors improvements ✨ in progress 🚧 In-PR 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants