Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & Consolidate NuGet packages #3288

Closed
michael-hawker opened this issue May 15, 2020 · 2 comments · Fixed by #3291 or #3301
Closed

Update & Consolidate NuGet packages #3288

michael-hawker opened this issue May 15, 2020 · 2 comments · Fixed by #3291 or #3301

Comments

@michael-hawker
Copy link
Member

Describe the bug

We have a few NuGet packages which we can Consolidate as well as update.

There's also a deprecated Microsoft.SourceLink.Vsts.Git package which I think we can just remove? @azchohfi?

We do need to fix the style in the Sample App to move to WinUI 2.4 though, so that'll be a bit of work. Otherwise, I think everything else should be fairly straight-forward and safe?

@azchohfi
Copy link
Contributor

@Sergio0694
Copy link
Member

We should definitely also update the Win2D dependency in the .Media package to 1.25.0:

https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/ae4000bcc6cd8eb235b9915a811bd5ea1097169a/Microsoft.Toolkit.Uwp.UI.Media/Microsoft.Toolkit.Uwp.UI.Media.csproj#L46

Sorry I forgot in #3112, I hadn't noticed the new package then 😅

@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.