Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make WrapPanel be virtualized #3107

Closed
jtorjo opened this issue Jan 23, 2020 · 4 comments
Closed

[Feature] Make WrapPanel be virtualized #3107

jtorjo opened this issue Jan 23, 2020 · 4 comments
Assignees
Labels
feature request 📬 A request for new changes to improve functionality In-PR 🚀
Milestone

Comments

@jtorjo
Copy link

jtorjo commented Jan 23, 2020

Describe the problem this feature would solve

WrapPanel is an insanely cool control. However, for a LOT of items, it's insanely slow. Like, for roughly 2000 items, even in release mode it sometimes takes roughly 10 seconds to load.

Describe the solution

We already have a VirtualizedPanel in UWP, I'm assuming we could derive from that?

@jtorjo jtorjo added the feature request 📬 A request for new changes to improve functionality label Jan 23, 2020
@ghost ghost added the needs triage 🔍 label Jan 23, 2020
@ghost
Copy link

ghost commented Jan 23, 2020

Thanks for submitting a new feature request! I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

@michael-hawker
Copy link
Member

@jtorjo I believe the new recommendations are to use ItemsRepeater as a basis. We'll take a dependency on WinUI when we move the toolkit to WinUI3 (see #3106). At that point, we'll investigate re-writing some of the panels. I know @skendrot has an interest in this area as well.

@michael-hawker michael-hawker modified the milestones: future, WinU3 Jan 23, 2020
@jtorjo
Copy link
Author

jtorjo commented Jan 24, 2020

@jtorjo I believe the new recommendations are to use ItemsRepeater as a basis. We'll take a dependency on WinUI when we move the toolkit to WinUI3 (see #3106). At that point, we'll investigate re-writing some of the panels. I know @skendrot has an interest in this area as well.

Thanks! Quick question: is there a WrapPanel control here on in WinUI that would be virtualized. Or any workaround so that I could use that?

@skendrot skendrot self-assigned this Jan 31, 2020
@skendrot
Copy link
Contributor

I've started working on creating Layouts for the WrapPanel and the StaggeredPanel. These new Layouts will work with the new ItemsRepeater

@michael-hawker michael-hawker modified the milestones: WinU3, 6.1 Apr 2, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 📬 A request for new changes to improve functionality In-PR 🚀
Projects
None yet
Development

No branches or pull requests

4 participants