Merge pull request #3155 from vgromfeld/u/vgromfeld/removeUnusedFields

Remove IDE0059: Value assigned to variable is never used
CommunityToolkit · Mar 23, 2020 · 5e030db · 5e030db
2 parents abf77ed + d55bdd1
commit 5e030db
Show file tree

Hide file tree

Showing 62 changed files with 135 additions and 319 deletions.
diff --git a/Microsoft.Toolkit.Parsers/Markdown/Blocks/YamlHeaderBlock.cs b/Microsoft.Toolkit.Parsers/Markdown/Blocks/YamlHeaderBlock.cs
@@ -4,7 +4,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Text;
 using Microsoft.Toolkit.Parsers.Markdown.Helpers;
 
 namespace Microsoft.Toolkit.Parsers.Markdown.Blocks
@@ -108,8 +107,6 @@ internal static YamlHeaderBlock Parse(string markdown, int start, int end, out i
             }
 
             var result = new YamlHeaderBlock();
-            var keys = new List<string>();
-            var values = new List<string>();
             result.Children = new Dictionary<string, string>();
             foreach (var item in elements)
             {

diff --git a/Microsoft.Toolkit.Parsers/Markdown/Inlines/ImageInline.cs b/Microsoft.Toolkit.Parsers/Markdown/Inlines/ImageInline.cs
@@ -73,8 +73,6 @@ internal static void AddTripChars(List<InlineTripCharHelper> tripCharHelpers)
         /// <returns> A parsed markdown image, or <c>null</c> if this is not a markdown image. </returns>
         internal static InlineParseResult Parse(string markdown, int start, int end)
         {
-            int refstart = 0;
-
             // Expect a '!' character.
             if (start >= end || markdown[start] != '!')
             {
@@ -120,7 +118,7 @@ internal static InlineParseResult Parse(string markdown, int start, int end)
 
             if (pos < end && markdown[pos] == '[')
             {
-                refstart = pos;
+                int refstart = pos;
 
                 // Find the reference ']' character
                 while (pos < end)

diff --git a/Microsoft.Toolkit.Parsers/Markdown/MarkdownDocument.cs b/Microsoft.Toolkit.Parsers/Markdown/MarkdownDocument.cs
@@ -55,7 +55,7 @@ public MarkdownDocument()
         /// <param name="markdownText"> The markdown text. </param>
         public void Parse(string markdownText)
         {
-            Blocks = Parse(markdownText, 0, markdownText.Length, quoteDepth: 0, actualEnd: out int actualEnd);
+            Blocks = Parse(markdownText, 0, markdownText.Length, quoteDepth: 0, actualEnd: out _);
 
             // Remove any references from the list of blocks, and add them to a dictionary.
             for (int i = Blocks.Count - 1; i >= 0; i--)

diff --git a/Microsoft.Toolkit.Parsers/Rss/RssHelper.cs b/Microsoft.Toolkit.Parsers/Rss/RssHelper.cs
@@ -311,9 +311,9 @@ public static string TimeZoneToOffset(string tz)
 
             tz = tz.ToUpper().Trim();
 
-            if (timeZones.ContainsKey(tz))
+            if (TimeZones.ContainsKey(tz))
             {
-                return timeZones[tz].First();
+                return TimeZones[tz].First();
             }
 
             return null;
@@ -337,8 +337,7 @@ private static IEnumerable<string> GetImagesInHTMLString(string htmlString)
                 if (matchHeight.Success)
                 {
                     var heightValue = matchHeight.Groups["height"].Value;
-                    int size = 0;
-                    if (int.TryParse(heightValue, out size) && size < 10)
+                    if (int.TryParse(heightValue, out var heightIntValue) && heightIntValue < 10)
                     {
                         include = false;
                     }
@@ -348,8 +347,7 @@ private static IEnumerable<string> GetImagesInHTMLString(string htmlString)
                 if (matchWidth.Success)
                 {
                     var widthValue = matchWidth.Groups["width"].Value;
-                    int size = 0;
-                    if (int.TryParse(widthValue, out size) && size < 10)
+                    if (int.TryParse(widthValue, out var widthIntValue) && widthIntValue < 10)
                     {
                         include = false;
                     }
@@ -376,7 +374,7 @@ private static IEnumerable<string> GetImagesInHTMLString(string htmlString)
         /// <summary>
         /// Dictionary of timezones.
         /// </summary>
-        private static Dictionary<string, string[]> timeZones = new Dictionary<string, string[]>
+        private static readonly Dictionary<string, string[]> TimeZones = new Dictionary<string, string[]>
         {
             { "ACDT", new[] { "-1030", "Australian Central Daylight" } },
             { "ACST", new[] { "-0930", "Australian Central Standard" } },

diff --git a/Microsoft.Toolkit.Services/OAuth/OAuthParameter.cs b/Microsoft.Toolkit.Services/OAuth/OAuthParameter.cs
@@ -49,7 +49,7 @@ public override string ToString()
         /// <returns>Formatted string of key / value.</returns>
         public string ToString(bool withQuotes)
         {
-            string format = null;
+            string format;
             if (withQuotes)
             {
                 format = "{0}=\"{1}\"";

diff --git a/Microsoft.Toolkit.Uwp.Connectivity/BluetoothLEHelper/ObservableGattDeviceService.cs b/Microsoft.Toolkit.Uwp.Connectivity/BluetoothLEHelper/ObservableGattDeviceService.cs
@@ -48,7 +48,7 @@ public ObservableGattDeviceService(GattDeviceService service)
             Service = service;
             Name = GattUuidsService.ConvertUuidToName(service.Uuid);
             UUID = Service.Uuid.ToString();
-            var t = GetAllCharacteristics();
+            _ = PopulateAllCharacteristicsAsync();
         }
 
         /// <summary>
@@ -147,10 +147,10 @@ protected virtual void OnPropertyChanged([CallerMemberName] string propertyName
         }
 
         /// <summary>
-        /// Gets all the characteristics of this service
+        /// Populate the characteristics in <see cref="Characteristics"/>.
         /// </summary>
         /// <returns>The status of the communication with the GATT device.</returns>
-        private async Task<GattCommunicationStatus> GetAllCharacteristics()
+        private async Task<GattCommunicationStatus> PopulateAllCharacteristicsAsync()
         {
             var tokenSource = new CancellationTokenSource(5000);
             var getCharacteristicsTask = await Task.Run(

diff --git a/....Toolkit.Uwp.Notifications/DesktopNotificationManager/DesktopNotificationManagerCompat.cs b/....Toolkit.Uwp.Notifications/DesktopNotificationManager/DesktopNotificationManagerCompat.cs
@@ -181,13 +181,13 @@ public static bool IsRunningAsUwp()
                     else
                     {
                         int length = 0;
-                        StringBuilder sb = new StringBuilder(0);
-                        int result = GetCurrentPackageFullName(ref length, sb);
+                        var sb = new StringBuilder(0);
+                        GetCurrentPackageFullName(ref length, sb);
 
                         sb = new StringBuilder(length);
-                        result = GetCurrentPackageFullName(ref length, sb);
+                        int error = GetCurrentPackageFullName(ref length, sb);
 
-                        _isRunningAsUwp = result != APPMODEL_ERROR_NO_PACKAGE;
+                        _isRunningAsUwp = error != APPMODEL_ERROR_NO_PACKAGE;
                     }
                 }
 

diff --git a/Microsoft.Toolkit.Uwp.Notifications/Toasts/Builder/ToastContentBuilder.Actions.cs b/Microsoft.Toolkit.Uwp.Notifications/Toasts/Builder/ToastContentBuilder.Actions.cs
@@ -5,7 +5,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 
 namespace Microsoft.Toolkit.Uwp.Notifications
 {
@@ -198,8 +197,8 @@ public ToastContentBuilder AddComboBox(string id, string title, string defaultSe
 
             for (int i = 0; i < choices.Count(); i++)
             {
-                var choice = choices.ElementAt(i);
-                box.Items.Add(new ToastSelectionBoxItem(choice.comboBoxItemId, choice.comboBoxItemContent));
+                var (comboBoxItemId, comboBoxItemContent) = choices.ElementAt(i);
+                box.Items.Add(new ToastSelectionBoxItem(comboBoxItemId, comboBoxItemContent));
             }
 
             return AddToastInput(box);
@@ -208,7 +207,7 @@ public ToastContentBuilder AddComboBox(string id, string title, string defaultSe
         /// <summary>
         /// Add an input option to the Toast.
         /// </summary>
-        /// <param name="input">An instance of a class that impmement <see cref="IToastInput"/> that will be used on the toast.</param>
+        /// <param name="input">An instance of a class that implement <see cref="IToastInput"/> that will be used on the toast.</param>
         /// <returns>The current instance of <see cref="ToastContentBuilder"/></returns>
         public ToastContentBuilder AddToastInput(IToastInput input)
         {

diff --git a/Microsoft.Toolkit.Uwp.Notifications/Toasts/ToastPeople.cs b/Microsoft.Toolkit.Uwp.Notifications/Toasts/ToastPeople.cs
@@ -31,7 +31,7 @@ public sealed class ToastPeople
 
         internal void PopulateToastElement(Element_Toast toast)
         {
-            string hintPeople = null;
+            string hintPeople;
 
             if (RemoteId != null)
             {

diff --git a/Microsoft.Toolkit.Uwp.PlatformDifferencesGen/Program.cs b/Microsoft.Toolkit.Uwp.PlatformDifferencesGen/Program.cs
@@ -191,15 +191,11 @@ public static string AssemblyDirectory
 
         private static Dictionary<string, List<string>> ProcessAssembly(Assembly assembly)
         {
-            int pos = assembly.FullName.IndexOf(", Culture");
-
-            string fileName = $"{assembly.FullName.Substring(0, pos)}.json";
-
-            Dictionary<string, List<string>> types = new Dictionary<string, List<string>>();
+            var types = new Dictionary<string, List<string>>();
 
             foreach (var exportedType in assembly.ExportedTypes)
             {
-                List<string> members = new List<string>();
+                var members = new List<string>();
 
                 if (exportedType.IsEnum)
                 {

diff --git a/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/Analyzer.cs b/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/Analyzer.cs
@@ -314,9 +314,7 @@ public static HowToGuard GetGuardForSymbol(ISymbol target)
 
         private static TypePresenceIndicator CheckCollectionForType(Dictionary<string, List<NewMember>> collection, string typeName, ISymbol symbol)
         {
-            List<NewMember> newMembers = null;
-
-            if (!collection.TryGetValue(typeName, out newMembers))
+            if (!collection.TryGetValue(typeName, out var newMembers))
             {
                 return TypePresenceIndicator.NotFound;
             }

diff --git a/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/PlatformSpecificAnalyzerCS.cs b/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/PlatformSpecificAnalyzerCS.cs
@@ -202,10 +202,7 @@ private void AnalyzeExpression(SyntaxNodeAnalysisContext context, ConcurrentDict
             }
 
             var line = loc.GetLineSpan().StartLinePosition.Line;
-
-            Diagnostic diagnostic = null;
-
-            if (reports.TryGetValue(line, out diagnostic) && diagnostic.Location.SourceSpan.Start <= loc.SourceSpan.Start)
+            if (reports.TryGetValue(line, out var diagnostic) && diagnostic.Location.SourceSpan.Start <= loc.SourceSpan.Start)
             {
                 return;
             }

diff --git a/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/PlatformSpecificAnalyzerVB.cs b/Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer/PlatformSpecificAnalyzerVB.cs
@@ -226,10 +226,7 @@ private void AnalyzeExpression(SyntaxNodeAnalysisContext context, ConcurrentDict
             }
 
             var line = loc.GetLineSpan().StartLinePosition.Line;
-
-            Diagnostic diagnostic = null;
-
-            if (reports.TryGetValue(line, out diagnostic) && diagnostic.Location.SourceSpan.Start <= loc.SourceSpan.Start)
+            if (reports.TryGetValue(line, out var diagnostic) && diagnostic.Location.SourceSpan.Start <= loc.SourceSpan.Start)
             {
                 return;
             }

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/Pages/SampleController.xaml.cs b/Microsoft.Toolkit.Uwp.SampleApp/Pages/SampleController.xaml.cs
@@ -8,7 +8,6 @@
 using System.Linq;
 using System.Reflection;
 using System.Runtime.CompilerServices;
-using System.Threading.Tasks;
 using Microsoft.Toolkit.Uwp.SampleApp.Common;
 using Microsoft.Toolkit.Uwp.SampleApp.Controls;
 using Microsoft.Toolkit.Uwp.SampleApp.Models;
@@ -165,7 +164,7 @@ public void RefreshXamlRender()
         {
             if (CurrentSample != null)
             {
-                var code = string.Empty;
+                string code;
                 if (InfoAreaPivot.SelectedItem == PropertiesPivotItem)
                 {
                     code = CurrentSample.BindedXamlCode;

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ImageCache/ImageCachePage.xaml.cs b/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ImageCache/ImageCachePage.xaml.cs
@@ -66,7 +66,7 @@ private async Task PreCacheImages(bool loadInMemory = false)
         private async Task LoadDataAsync()
         {
             var source = new PhotosDataSource();
-            _photoItems = await new PhotosDataSource().GetItemsAsync(true);
+            _photoItems = await source.GetItemsAsync(true);
         }
 
         private async void PreCache_Tapped(object sender, RoutedEventArgs e)

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LinkedIn Service/LinkedInPage.xaml.cs b/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LinkedIn Service/LinkedInPage.xaml.cs
@@ -39,7 +39,7 @@ private async void ConnectButton_Click(object sender, RoutedEventArgs e)
                 CallbackUri = CallbackUri.Text
             };
 
-            var succeeded = LinkedInService.Instance.Initialize(oAuthTokens, LinkedInPermissions.ReadBasicProfile | LinkedInPermissions.WriteShare);
+            LinkedInService.Instance.Initialize(oAuthTokens, LinkedInPermissions.ReadBasicProfile | LinkedInPermissions.WriteShare);
 
             var loggedIn = await LinkedInService.Instance.LoginAsync();
 
@@ -66,7 +66,7 @@ private async void ShareButton_Click(object sender, RoutedEventArgs e)
                 return;
             }
 
-            var response = await LinkedInService.Instance.ShareActivityAsync(ShareText.Text);
+            await LinkedInService.Instance.ShareActivityAsync(ShareText.Text);
 
             var message = new MessageDialog("Share sent to LinkedIn");
             await message.ShowAsync();

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LiveTile/LiveTilePage.xaml.cs b/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/LiveTile/LiveTilePage.xaml.cs
@@ -170,7 +170,7 @@ private void Initialize()
                 tile.VisualElements.Square150x150Logo = Constants.Square150x150Logo;
                 tile.VisualElements.Wide310x150Logo = Constants.Wide310x150Logo;
                 tile.VisualElements.Square310x310Logo = Constants.Square310x310Logo;
-                var dontWait = tile.UpdateAsync(); // Commit changes (no need to await)
+                _ = tile.UpdateAsync(); // Commit changes (no need to await)
 
                 tile.CreateTileUpdater().Update(new TileNotification(_tileContent.GetXml()));
             }

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/MarkdownTextBlock/MarkdownTextBlockPage.xaml.cs b/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/MarkdownTextBlock/MarkdownTextBlockPage.xaml.cs
@@ -57,7 +57,7 @@ private void Current_ThemeChanged(object sender, Models.ThemeChangedArgs e)
 
         private async void MarkdownText_ImageClicked(object sender, LinkClickedEventArgs e)
         {
-            if (!Uri.TryCreate(e.Link, UriKind.Absolute, out Uri result))
+            if (!Uri.IsWellFormedUriString(e.Link, UriKind.Absolute))
             {
                 await new MessageDialog("Masked relative Images needs to be manually handled.").ShowAsync();
             }
@@ -91,7 +91,7 @@ private void SetInitalText(string text)
 
         private async void MarkdownText_LinkClicked(object sender, LinkClickedEventArgs e)
         {
-            if (!Uri.TryCreate(e.Link, UriKind.Absolute, out Uri result))
+            if (!Uri.IsWellFormedUriString(e.Link, UriKind.Absolute))
             {
                 await new MessageDialog("Masked relative links needs to be manually handled.").ShowAsync();
             }

diff --git a/...kit.Uwp.SampleApp/SamplePages/WeatherLiveTileAndToast/WeatherLiveTileAndToastPage.xaml.cs b/...kit.Uwp.SampleApp/SamplePages/WeatherLiveTileAndToast/WeatherLiveTileAndToastPage.xaml.cs
@@ -314,7 +314,7 @@ private void Initialize()
                 tile.VisualElements.Square150x150Logo = Constants.Square150x150Logo;
                 tile.VisualElements.Wide310x150Logo = Constants.Wide310x150Logo;
                 tile.VisualElements.Square310x310Logo = Constants.Square310x310Logo;
-                var dontWait = tile.UpdateAsync(); // Commit changes (no need to await)
+                _ = tile.UpdateAsync(); // Commit changes (no need to await)
 
                 tile.CreateTileUpdater().Update(new TileNotification(_tileContent.GetXml()));
             }

diff --git a/Microsoft.Toolkit.Uwp.SampleApp/Shell.SamplePicker.cs b/Microsoft.Toolkit.Uwp.SampleApp/Shell.SamplePicker.cs
@@ -36,11 +36,11 @@ private Sample CurrentSample
             set
             {
                 _currentSample = value;
-                var nop = SetNavViewSelection();
+                _ = SetNavViewSelectionAsync();
             }
         }
 
-        private async Task SetNavViewSelection()
+        private async Task SetNavViewSelectionAsync()
         {
             if (_currentSample != null)
             {
@@ -59,10 +59,10 @@ private async Task SetNavViewSelection()
 
         private void HideSamplePicker()
         {
-            SamplePickerGrid.Visibility = Windows.UI.Xaml.Visibility.Collapsed;
+            SamplePickerGrid.Visibility = Visibility.Collapsed;
             _selectedCategory = null;
 
-            var noop = SetNavViewSelection();
+            _ = SetNavViewSelectionAsync();
         }
 
         private async void ShowSamplePicker(Sample[] samples = null, bool group = false)
@@ -323,7 +323,7 @@ private void HideMoreInfo()
                     animation.Configuration = new DirectConnectedAnimationConfiguration();
                 }
 
-                var t = SamplePickerGridView.TryStartConnectedAnimationAsync(animation, MoreInfoContent.DataContext, "SampleIcon");
+                _ = SamplePickerGridView.TryStartConnectedAnimationAsync(animation, MoreInfoContent.DataContext, "SampleIcon");
             }
 
             MoreInfoContent.DataContext = null;

diff --git a/Microsoft.Toolkit.Uwp.UI.Animations/ConnectedAnimations/ConnectedAnimationHelper.cs b/Microsoft.Toolkit.Uwp.UI.Animations/ConnectedAnimations/ConnectedAnimationHelper.cs
@@ -50,8 +50,7 @@ internal void SetParameterForNextFrameNavigation(object parameter)
 
         private void Frame_Navigating(object sender, Windows.UI.Xaml.Navigation.NavigatingCancelEventArgs e)
         {
-            object parameter = null;
-
+            object parameter;
             if (_nextParameter != null)
             {
                 parameter = _nextParameter;

diff --git a/Microsoft.Toolkit.Uwp.UI.Animations/Expressions/ExpressionNodes/ExpressionNode.cs b/Microsoft.Toolkit.Uwp.UI.Animations/Expressions/ExpressionNodes/ExpressionNode.cs
@@ -473,7 +473,7 @@ private string GetOperationString()
 
         private string ToExpressionStringInternal()
         {
-            string ret = string.Empty;
+            string ret;
 
             // Do a recursive depth-first traversal of the node tree to print out the full expression string
             switch (GetOperationKind())

diff --git a/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/Automation/DataGridAutomationPeer.cs b/Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/Automation/DataGridAutomationPeer.cs
@@ -724,8 +724,7 @@ internal void PopulateItemPeers()
                 {
                     if (item != null)
                     {
-                        DataGridItemAutomationPeer peer = null;
-
+                        DataGridItemAutomationPeer peer;
                         if (oldChildren.ContainsKey(item))
                         {
                             peer = oldChildren[item] as DataGridItemAutomationPeer;