Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

[th] Update validate and cleanup before the next corpus release date #447

Merged
merged 4 commits into from
Jun 9, 2021
Merged

[th] Update validate and cleanup before the next corpus release date #447

merged 4 commits into from
Jun 9, 2021

Conversation

bact
Copy link
Contributor

@bact bact commented Jun 7, 2021

Cleanup

  • Remove a space after ending sentence marks (: ? ! Maiyamok .) and before closing quotation marks (' " ” ’).

Before the fix:
'คุณเตือนฉัน ! ' กษัตริย์พูด

After the fix:
'คุณเตือนฉัน !' กษัตริย์พูด

  • Remove erroneous tone marks, above/below vowel, and several other symbols at the beginning of a word

Before the fix:
่หมวกกันน็อคของคุณ

After the fix:
หมวกกันน็อคของคุณ

Validation

  • Increase the sentence's max character counts to 100 (was 80)
  • Adjust rules on running characters without a space to be more specific to character categories
  • Reorder/group rules

bact added 3 commits June 7, 2021 12:53
…quotation mark.

Validation: increase sentence max length and add few rules to check running characters without a space
@MichaelKohler
Copy link
Member

Thanks, I'll have a look tomorrow!

MichaelKohler
MichaelKohler previously approved these changes Jun 9, 2021
Copy link
Member

@MichaelKohler MichaelKohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

server/lib/validation/languages/th.js Outdated Show resolved Hide resolved
@MichaelKohler MichaelKohler merged commit fb2911d into common-voice:main Jun 9, 2021
MichaelKohler pushed a commit that referenced this pull request Jun 9, 2021
## [2.4.4](v2.4.3...v2.4.4) (2021-06-09)

### Bug Fixes

* [th] Update validate and cleanup before the next corpus release date ([#447](#447)) ([fb2911d](fb2911d))
@MichaelKohler
Copy link
Member

🎉 This PR is included in version 2.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bact bact deleted the update-th-validate branch June 10, 2021 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants