Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Keep Searchbox open to import multiple nodes #2004

Open
1 task done
LukeG89 opened this issue Dec 21, 2024 · 6 comments
Open
1 task done

[Feature Request]: Keep Searchbox open to import multiple nodes #2004

LukeG89 opened this issue Dec 21, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@LukeG89
Copy link

LukeG89 commented Dec 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

When using the Searchbox via double-click or shortcut, it currently closes automatically after selecting a node. While this might be convenient in some cases, it can also be restrictive when you're in the building process and want to explore multiple options.

For instance, if you've filtered search results by keyword, or specific node, input or output types, you may want to import several nodes that match your criteria. However, everytime the Searchbox is closed, all your filtering is lost; you have to re-enter the same keywords and filters every time you reopen it. This can be frustrating and inefficient.

While you can use the Node Library to find and import multiple nodes, using the Searchbox during the building process often feels more intuitive and natural. It would be helpful to have the option to keep the Searchbox open after selecting a node, allowing you to continue searching, filtering, and importing additional nodes.

Proposed workflow

  • Open Searchbox using double-click or shortcut
  • Find specific node types by searching and filtering
  • Choose one or more nodes to add them to your workflow
  • Click on canvas to close Searchbox when done

Additional information

No response

┆Issue is synchronized with this Notion page by Unito

@LukeG89 LukeG89 added the enhancement New feature or request label Dec 21, 2024
@LukeG89
Copy link
Author

LukeG89 commented Jan 7, 2025

@huchenlei In case you don't want to make it a normal behavior, would it be possible to add an user option in Settings or a checkbox/switch to the Searchbox itself to keep it open?

@christian-byrne
Copy link
Collaborator

I like the idea. I can write and propose an implementation of the setting. I can also do the same for the node filter dialog.

@christian-byrne
Copy link
Collaborator

What do you think of having option to preserve search context, rather than keeping the searchbox open while adding? Like this:

persist-search-context.mp4

When the searchbox stays open as you add, the nodes stack on top of one another and there is not very good visual feedback. It becomes hard to tell what you've added, and you are forced to rearrange afterwards since they are stacked.

@LukeG89
Copy link
Author

LukeG89 commented Jan 7, 2025

What do you think of having option to preserve search context, rather than keeping the searchbox open while adding?
When the searchbox stays open as you add, the nodes stack on top of one another and there is not very good visual feedback.

@christian-byrne Yeah, you're right about that!
But how to reset both keywords and filtering after we "finished" searching?

@christian-byrne
Copy link
Collaborator

I guess the standard solution would be to automatically select the restored content so it can be deleted without any additional keystrokes. Similar to Ctrl+F feature in browsers. You would also need to be able to delete filter chips with backspace.

Persistent search context was also requested here.

@christian-byrne
Copy link
Collaborator

Currently there are issues with the extendability of the AutoComplete component. In particular, the input element is not well exposed. However, I think search component and service will eventually be extended for features like:

The implementation of these features will most likely entail an easy way to persist search context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants