Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build type to use provided dependencies #412

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Change build type to use provided dependencies #412

merged 1 commit into from
Apr 16, 2018

Conversation

marcinczeczko
Copy link
Contributor

Description

In order to better manage dependencies Knot.x modules should use provided scope

Motivation and Context

  • to better control dependencies in the stack

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@marcinczeczko marcinczeczko merged commit 9a7e2c3 into milestone/backpressure-and-configs Apr 16, 2018
@marcinczeczko marcinczeczko deleted the feature/deps-to-provided branch April 16, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malaskowski malaskowski malaskowski approved these changes

@tomaszmichalak tomaszmichalak Awaiting requested review from tomaszmichalak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backpressure and Configuration [1.3.0]
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinczeczko @malaskowski