Extract knotx core into a single module #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-knotx-core-as-one-module
tomaszmichalak
requested changes
Mar 22, 2018
| "fsRepo=io.knotx.repository.FilesystemRepositoryConnectorVerticle", | ||
| "splitter=io.knotx.knot.splitter.FragmentSplitterVerticle", | ||
| "assembler=io.knotx.knot.assembler.FragmentAssemblerVerticle", | ||
| "httpRepo=io.knotx.repository.http.HttpRepositoryConnectorVerticle", |
There was a problem hiding this comment.
io.knotx.core.repository....
| "assembler=io.knotx.knot.assembler.FragmentAssemblerVerticle", | ||
| "httpRepo=io.knotx.repository.http.HttpRepositoryConnectorVerticle", | ||
| "fsRepo=io.knotx.repository.fs.FilesystemRepositoryConnectorVerticle", | ||
| "splitter=io.knotx.splitter.FragmentSplitterVerticle", |
| "httpRepo=io.knotx.repository.http.HttpRepositoryConnectorVerticle", | ||
| "fsRepo=io.knotx.repository.fs.FilesystemRepositoryConnectorVerticle", | ||
| "splitter=io.knotx.splitter.FragmentSplitterVerticle", | ||
| "assembler=io.knotx.assembler.FragmentAssemblerVerticle", |
| @@ -63,7 +63,8 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.knotx</groupId> | |||
| <artifactId>knotx-junit</artifactId> | |||
| <artifactId>knotx-core</artifactId> | |||
There was a problem hiding this comment.
Please add the comment that this dependency is temporary.
| @@ -68,7 +68,8 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>io.knotx</groupId> | |||
| <artifactId>knotx-junit</artifactId> | |||
| <artifactId>knotx-core</artifactId> | |||
| @@ -13,13 +13,12 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package io.knotx.knot.assembler.impl; | |||
| package io.knotx.assembler; | |||
There was a problem hiding this comment.
Can we set package name to io.knotx.core.assembler ?
| @@ -13,7 +13,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package io.knotx.gateway.impl; | |||
| package io.knotx.gateway; | |||
| @@ -13,12 +13,11 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package io.knotx.repository.impl; | |||
| package io.knotx.repository.fs; | |||
There was a problem hiding this comment.
io.knotx.core.repository
tomaszmichalak
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Knot.x is fully extensible tool. However there are parts that are the core of Knot.x This pull request identifies those modules and merges them into a single knotx-core module.
Motivation and Context
The idea here is to have one
knotx-coremodule that will be the very base of Knot.x. In the future it will be the heart of the whole system. This change will enable easier maintenance and more clear approach to Knot.x extendability.Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.