Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #314 - Knot.x returns exit code 20 in case of missing config fi… #318

Merged
merged 4 commits into from
Aug 4, 2017

Conversation

marcinczeczko
Copy link
Contributor

@marcinczeczko marcinczeczko commented Aug 4, 2017

Fixed #314 - Knot.x returns exit code 30 in case of missing config file or empty config file

@@ -40,6 +40,10 @@ To start Knot.x with custom modules, use following command
java -Dlogback.configurationFile=logback.xml -cp "app/*" io.knotx.launcher.LogbackLauncher -conf knotx-starter.json
```

The execution of Knot.x using a launcher as above it uses a following exit codes as specified in [Vert.x documentation|http://vertx.io/docs/vertx-core/java/#_launcher_and_exit_code].
Additionally, Knot.x adds following exit codes:
- `20` - If the configuration is missing or it's empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 30 ?

/**
* Error code used when the knotx configuration is missing or it's empty
*/
public static final int KNOTX_MISSING_OR_EMPTY_CONFIGURATION_EXIT_CODE = 30;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe here should be 20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated changelog.

@marcinczeczko marcinczeczko merged commit 6ad596b into master Aug 4, 2017
@malaskowski malaskowski deleted the bugfix/314 branch August 4, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants