Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRepositoryConnectorProxyImpl should encode parameter names #394

Closed
piotr-wilczynski opened this issue Mar 20, 2018 · 1 comment
Closed

HttpRepositoryConnectorProxyImpl should encode parameter names #394

piotr-wilczynski opened this issue Mar 20, 2018 · 1 comment
Labels
bug

Comments

@piotr-wilczynski
Copy link
Contributor

Version used

  • knot.x: 1.2.1

Context of the issue/feature

HttpRepositoryConnectorProxyImpl:141 is not encoding parameter names and return 400 error.

Bug reproducer

Steps to reproduce

Try to use knotx with request /content/home.html?parameter%20with%20space=value

Actual
400 error code
Expected
200 success code
piotr-wilczynski added a commit that referenced this issue Mar 20, 2018
@piotr-wilczynski
#394
be75c37 
Added encoding of uri parameter names
@piotr-wilczynski
Copy link
Contributor Author

pr created https://github.com/Cognifide/knotx/pull/395/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piotr-wilczynski