-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating correct correlationId when suite name is overridden #461
Generating correct correlationId when suite name is overridden #461
Conversation
@@ -71,7 +71,7 @@ public TestSuiteRun(TestSuiteRun testSuiteRun, String name, String domain, List< | |||
this.company = testSuiteRun.getCompany(); | |||
this.project = testSuiteRun.getProject(); | |||
this.domain = domain; | |||
this.correlationId = testSuiteRun.getCorrelationId(); | |||
this.correlationId = CorrelationIdGenerator.generateCorrelationId(company, project, name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this class has 2 constructors and now the 2nd constructor could use the 1st one to reduce the amount of code, what do you think? E.g. 2nd constructors could be changed to:
public TestSuiteRun(TestSuiteRun testSuiteRun, String name, String domain, List<TestRun> tests) {
this(name, testSuiteRun.getCompany(), testSuiteRun.getProject(), domain, tests);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion, it seems like a reasonable thing to do.
Can you add some unit tests for TestSuiteRun or SuiteExecutor (see which fits better) which test if correlation ID is correct when the suite name is overriden? Just to make sure that noone will break this again accidentally when doing some refactoring :) |
I fixed generating correlationId with suite name overridden in command line. For details see #440.
Description
CorrelationId now contains overridden suite name instead of the value from XML file.
Motivation and Context
Closes #440
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.