-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade codesniffer to 3.2.0 #430
Merged
malaskowski
merged 13 commits into
wttech:master
from
wblachowski:feature/upgrade-html-codesniffer
Nov 21, 2018
Merged
Upgrade codesniffer to 3.2.0 #430
malaskowski
merged 13 commits into
wttech:master
from
wblachowski:feature/upgrade-html-codesniffer
Nov 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good job! Please update Changelog with this PR |
malaskowski
reviewed
Nov 14, 2018
* changed scope of variable to window | ||
* added HTMLCS.getMessagesJSON() | ||
*/ | ||
(function (root, factory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not look like minified file.
But I see that previous versions was not minified also (and was named ...min.js
).
# Conflicts: # CHANGELOG.md
This reverts commit 7f37d8b
malaskowski
approved these changes
Nov 19, 2018
Tested & accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded AccessSniff to version 3.2.0 (issue #420)
Description
Htmlcs js has been updated to AccessSniff 3.2.0. All custom code has been incorporated into new version (the custom changes are listed in comment at the top of the file).
I hereby agree to the terms of the AET Contributor License Agreement.