Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/conditional test acceptance #403

Merged
merged 7 commits into from
Oct 19, 2018

Conversation

ernestosiak
Copy link
Contributor

Tests that passed conditionally can now be accepted

Description

Any test that passed conditionally can be accepted and new pattern will be saved. This feature will be available to test that normally, when failed, can be accepted, but have passed with condition.

Motivation and Context

Issue 400

Screenshots (if appropriate):

fixed-accept-conditional

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Contributor

@wiiitek wiiitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! :)

@tkaik tkaik merged commit 271dc56 into master Oct 19, 2018
@tkaik tkaik deleted the feature/conditional-test-acceptance branch October 19, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants